Change in openvpn[master]: GHA: Run openvpnserv UT for MinGW builds
A message that is not in the archive (sent off-list or not yet received): gerrit.1769435786000.If61a91b4580864fd22162c94467ba3dda2045b7b@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email
to review the following change.
Change subject: GHA: Run openvpnserv UT for MinGW builds
......................................................................
GHA: Run openvpnserv UT for MinGW builds
Should have been added in commitb10ee38ccde5f155d02fcd3e8f1b1ab454826ab0.
Note that test_openvpnserv.exe lives in a
separate directory, so we need to make the
code a bit more flexible.
---
M .github/workflows/build.yaml
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/1
.github/workflows/build.yaml +6 -4
@@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe - uses: actions/[email protected]... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/*.dll mingw-unittest:
@@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pass] build: [Release, Debug] runs-on: windows-2025
@@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=(Get-ChildItem -Path unittests -Filter test_${{ matrix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email )
Change subject: GHA: Run openvpnserv UT for MinGW builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 26 Jan 2026 15:10:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v2 1/1 GHA: Run openvpnserv UT for MinGW builds
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Should have been added in commitb10ee38ccde5f155d02fcd3e8f1b1ab454826ab0.
Note that test_openvpnserv.exe lives in a
separate directory, so we need to make the
code a bit more flexible.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
.github/workflows/build.yaml +6 -4
@@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe - uses: actions/[email protected]... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/*.dll mingw-unittest:
@@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pass] build: [Release, Debug] runs-on: windows-2025
@@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=(Get-ChildItem -Path unittests -Filter test_${{ matrix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn"
[Openvpn-devel] [PATCH applied] Re: GHA: Run openvpnserv UT for MinGW builds
Tested this by pushing to my own GH Repo, and looking at the results - while GH does have a bad day (half the "do things on a windows worker" things failed without any explanation beyond "This job failed"), it *did* build and run the test that is interesting here, so in it goes. Thanks :-)
Your patch has been applied to the master branch.
commit 447d04fe5058c782d727419f44a3f8248a3007ce
Author: Frank Lichtenheld Date: Mon Jan 26 16:11:16 2026 +0100
GHA: Run openvpnserv UT for MinGW builds
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
Message-Id: <[email protected]...>
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: GHA: Run openvpnserv UT for MinGW builds
......................................................................
GHA: Run openvpnserv UT for MinGW builds
Should have been added in commitb10ee38ccde5f155d02fcd3e8f1b1ab454826ab0.
Note that test_openvpnserv.exe lives in a
separate directory, so we need to make the
code a bit more flexible.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
Message-Id: <[email protected]...>
---
M .github/workflows/build.yaml
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/3
.github/workflows/build.yaml +6 -4
@@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe - uses: actions/[email protected]... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/*.dll mingw-unittest:
@@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pass] build: [Release, Debug] runs-on: windows-2025
@@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=(Get-ChildItem -Path unittests -Filter test_${{ matrix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email )
Change subject: GHA: Run openvpnserv UT for MinGW builds
......................................................................
GHA: Run openvpnserv UT for MinGW builds
Should have been added in commitb10ee38ccde5f155d02fcd3e8f1b1ab454826ab0.
Note that test_openvpnserv.exe lives in a
separate directory, so we need to make the
code a bit more flexible.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
Message-Id: <[email protected]...>
---
M .github/workflows/build.yaml
1 file changed, 6 insertions(+), 4 deletions(-)
.github/workflows/build.yaml +6 -4
@@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe - uses: actions/[email protected]... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.build }}/*.dll mingw-unittest:
@@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pass] build: [Release, Debug] runs-on: windows-2025
@@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=(Get-ChildItem -Path unittests -Filter test_${{ matrix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>